Dev #49
Merged
Dev #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added version checker to modal and version check endpoint * Added version check to twitch chat connection * Removed unused import * Updated chatFeedAlert method and used on Main * Renamed some vars
* Basically stashing this, it seems like it'll break stuff * Moved Track Details to TrackService, Introduced various services to help with organization * JSDocs * Removed unused import, updated jsdocs * Moved Device to Spotify class and created unit tests * Made Unit Tests for SpotifyService * Moved Test Data to its own file, updated Spotify Service tests * Created unit tests for Strings helpers * Unit test for Timing * Renamed method, getErrorMessage unit tests * Fixed edge cases on getErrorMessage and updated tests * Created workflow to (hopefully) enforce unit tests on PR to Main * Unit tests for getBiggestImageUrl * Added Dev to Unit Test workflow * Formatted Lyrics on load and used that to save on casts every tick * Unit tests for Playlists and some renames * Fixed condition in Array test and optimized tests * Added missing case to timing unit tests * Moved tests to be near their corresponding class definition, implemented unit tests for Track Service * Implemented Unit Tests for QueueService * renamed jest tests workflow name
* Green on initial SpotifyPlayer test * Green on Playlist updated with Null test * fixed null update test * Green on Default Getters test on Lyrics Service * Green on Lyrics File exists test * Unit Tests for ProfileService, renamed ProfileService to `user` to make it more obvious * Fixed typing on Api Fetch * Initial API Unit Tests * Updated error code test * Fixed some errors that Github didn't handle the same way as local dev
* Added new variables to Playlist, updated test to use more reliable property * Fixed other param that could be simplified * Fixed incorrect return * Forgot those were API links, oops * Updated Tests
* Changed enforce dev to main workflow to only show up in Main PRs * Organized tests and made workflow output verbose
* Changed enforce dev to main workflow to only show up in Main PRs * Organized tests and made workflow output verbose * Fixed workflow conditions * Fixed workflow conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.