r.flowaccumulation: Handle null values properly #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuidaeCho
changed the title
wenzeslaus
reviewed
Nov 7, 2023
Comment on lines
+35
to
+41
| #ifdef _MAIN_C_ | ||
| #define GLOBAL | ||
| #else | ||
| #define GLOBAL extern | ||
| #endif | ||
|
|
||
| GLOBAL CELL cell_null; |
There was a problem hiding this comment.
Using Rast_is_c_null_value would avoid the need for an award global variable. Would Rast_is_c_null_value work here?
There was a problem hiding this comment.
Right, Rast_is_c_null_value should also work. That global was my attempt for micro-optimization. Just did a benchmark test against Rast_is_c_null_value. Well.. not much difference... Maybe, GCC can optimize out this function call as inline. Yeah.. not worth it.
There was a problem hiding this comment.
Benchmark! Nice! The function is in fact a macro, so it should be always inlined.
There was a problem hiding this comment.
Ah! I missed #ifndef Rast_is_c_null_value!
#ifndef Rast_is_c_null_value
int Rast_is_c_null_value(const CELL *cellVal)
{
/* Check if the CELL value matches the null pattern */
return *cellVal == (CELL)0x80000000;
}
#endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.