v.stream.inbasin: Modernize interface, fix for v8 #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wenzeslaus
commented
Jul 27, 2023
wenzeslaus
commented
- Changes x_outlet and y_outlet to single coordinates standard option which is recognized by GUI and user can click to get coordinates there. Call in Python has less parameters and same readability (x,y).
- Makes coordinates optional which seems to be the original intention.
- Uses rules to decide about valid options instead of custom if statements.
- Updates interfacing with numpy to Python 3.
- Adds more recent reference.
- Describes stream input more.
- Adds tests.
- Changes x_outlet and y_outlet to single coordinates standard option which is recognized by GUI and user can click to get coordinates there. Call in Python has less parameters and same readability (x,y). - Makes coordinates optional which seems to be the original intention. - Uses rules to decide about valid options instead of custom if statements. - Updates interfacing with numpy to Python 3. - Adds more recent reference. - Describes stream input more. - Adds tests.
awickert
approved these changes
Jul 29, 2023
There was a problem hiding this comment.
Thanks to @wenzeslaus, especially for knowing how to appropriately interface this to the various GRASS GIS interface options. Streamlining the code is also much appreciated!
cwhite911
pushed a commit
to cwhite911/grass-addons
that referenced
this pull request
Sep 19, 2023
- Changes x_outlet and y_outlet to single coordinates standard option which is recognized by GUI and user can click to get coordinates there. Call in Python has less parameters and same readability (x,y). - Makes coordinates optional which seems to be the original intention. - Uses rules to decide about valid options instead of custom if statements. - Updates interfacing with numpy to Python 3. - Adds more recent reference. - Describes stream input more. - Adds tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.