r.sun.daily: add average method #933
Conversation
to correspond with r.statistics
sorry, r.green changes were an unrelated work-in-pruogress code
| """ | ||
| maps = "+".join([basename + suf for suf in suffixes]) | ||
| grass.mapcalc( | ||
| "{out_} = ({new}) / {maps_count}".format( |
There was a problem hiding this comment.
I did consider it but wanted to keep the formatting that is used throughout the module. There are a few more places where this would be favoured, but I would prefer to change that in the entire module in another commit (making it easier to understand the reasoning behind commits through git blame).
There was a problem hiding this comment.
I can't blame you, but you are introducing new code here and there is no need to be consistent with old practices.
There was a problem hiding this comment.
I believe that it is clearer to keep the full-module practice and then change the practice in the whole module in another commit, but whatever. It seems like a minor nitpick aspect to me, so I don't feel any need to fight for that tooth and nail. Changed in 961aa5b.
You're right. Changed in 1969aba. |
No description provided.