Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.landsat.import: Adding tarfile member sanitization to extractall() (CVE-2007-4559 Patch) #843

Merged
merged 7 commits into from
Dec 29, 2023
Merged
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/imagery/i.landsat/i.landsat.import/i.landsat.import.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,25 @@ def _untar(inputdir, untardir):

for scene in scenes_to_untar:
with tarfile.open(name=scene, mode="r") as tar:
tar.extractall(untardir)

def is_within_directory(directory, target):
neteler marked this conversation as resolved.
Show resolved Hide resolved

abs_directory = os.path.abspath(directory)
abs_target = os.path.abspath(target)

prefix = os.path.commonprefix([abs_directory, abs_target])

return prefix == abs_directory

def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
for member in tar.getmembers():
member_path = os.path.join(path, member.name)
if not is_within_directory(path, member_path):
raise Exception("Attempted Path Traversal in Tar File")
echoix marked this conversation as resolved.
Show resolved Hide resolved

tar.extractall(path, members, numeric_owner=numeric_owner)

safe_extract(tar, untardir)

untared_tifs = glob.glob(os.path.join(untardir, "*.TIF"))
return untared_tifs
Expand Down
Loading