[16.0][ADD] stock_storage_type_putaway_abc_classification_sale_stock #497
Conversation
rousseldenis
force-pushed
the
16.0-add-stock_storage_type_abc_classification-dro
branch
2 times, most recently
from
a1ed4ee
to
21862a1
Compare
rousseldenis
force-pushed
the
16.0-add-stock_storage_type_abc_classification-dro
branch
from
21862a1
to
bd41be9
Compare
rousseldenis
changed the title
rousseldenis
force-pushed
the
16.0-add-stock_storage_type_abc_classification-dro
branch
from
bd41be9
to
980b444
Compare
| Evaluate the abc classification profile ids in order to retrieve | ||
| the corresponding one. | ||
| """ | ||
| location_level = products.abc_classification_product_level_ids.filtered( |
There was a problem hiding this comment.
@rousseldenis products means potentially a recordset with more than one product... Do we have to enforce that the method is always called with 1 product our do we have to take the first product into the recordset as into the initial implementation
There was a problem hiding this comment.
@jbaudoux Your input on this ? IMHO, we indeed could use ensure_one() as we must ensure location_level is 1.
There was a problem hiding this comment.
This can be called when computing the putaway of a stock.package.level for a mixed pallet containing multiple products.
Ideally we should get the main product of the set. first is current implementation but the product with the lowest (alphabetically) abc_storage would be a better implementation.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
jbaudoux
changed the title
|
ping @rousseldenis can you reopen this one. |
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
rousseldenis
added
no stale
rousseldenis
force-pushed
the
16.0-add-stock_storage_type_abc_classification-dro
branch
from
980b444
to
6830eb3
Compare
| """ | ||
| location_level = products.abc_classification_product_level_ids.filtered( | ||
| lambda level, location=self: level.profile_type == "sale_stock" | ||
| and level.profile_id.warehouse_id == location.warehouse_id |
There was a problem hiding this comment.
Where is location.warehouse_id coming from ? A location is not linked to a warehouse
Depends on: