Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_picking_comment_template: Migration to 17.0 #334

Merged

Conversation

RogerSans
Copy link

Standard migration
T-6459

@HaraldPanten
@ValentinVinagre
@luis-ron

emagdalenaC2i and others added 26 commits July 29, 2024 13:47
Currently translated at 100.0% (13 of 13 strings)

Translation: stock-logistics-reporting-12.0/stock-logistics-reporting-12.0-stock_picking_comment_template
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-12-0/stock-logistics-reporting-12-0-stock_picking_comment_template/ja/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-reporting-12.0/stock-logistics-reporting-12.0-stock_picking_comment_template
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-12-0/stock-logistics-reporting-12-0-stock_picking_comment_template/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-reporting-12.0/stock-logistics-reporting-12.0-stock_picking_comment_template
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-12-0/stock-logistics-reporting-12-0-stock_picking_comment_template/
Currently translated at 84.6% (11 of 13 strings)

Translation: stock-logistics-reporting-12.0/stock-logistics-reporting-12.0-stock_picking_comment_template
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-12-0/stock-logistics-reporting-12-0-stock_picking_comment_template/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_picking_comment_template
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_picking_comment_template/
@RogerSans RogerSans force-pushed the 17.0-mig-stock_picking_comment_template branch 4 times, most recently from d7e6ec0 to 4b5283e Compare July 30, 2024 08:03
@RogerSans RogerSans force-pushed the 17.0-mig-stock_picking_comment_template branch 3 times, most recently from 11c98f4 to e45a971 Compare July 30, 2024 10:15
@RogerSans RogerSans mentioned this pull request Jul 30, 2024
10 tasks
Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM 👍🏻

@RogerSans
Copy link
Author

@manuelregidor Can you review this pls?

}
)

def _create_comment(self, model, position):
def _create_comment_template_test(self, position):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to change the name and arguments of this method?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to the original. Fields have been simplified since by passing self you can now acquire the necessary field from there.

@RogerSans RogerSans force-pushed the 17.0-mig-stock_picking_comment_template branch from b860732 to e2b136d Compare July 31, 2024 09:07
@HaraldPanten
Copy link
Contributor

@pedrobaeza Do you mind assigning this migration to us? THX in advance

@pedrobaeza
Copy link
Member

/ocabot migration stock_picking_comment_template

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 31, 2024
Copy link

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review. LGTM

@HaraldPanten
Copy link
Contributor

@JordiBForgeFlow @LoisRForgeFlow could you merge, please? 🙏

@JordiBForgeFlow
Copy link
Sponsor Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-334-by-JordiBForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 85d366e into OCA:17.0 Aug 1, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 70d1422. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-mig-stock_picking_comment_template branch August 1, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.