Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] stock_delivery_sale_section_and_note #293

Closed
wants to merge 3 commits into from
Closed

[15.0][ADD] stock_delivery_sale_section_and_note #293

wants to merge 3 commits into from

Conversation

StephaneMangin
Copy link

This module provides the propagation of sale order sections/notes lines to the delivery slip reports.

@StephaneMangin StephaneMangin force-pushed the 15.0_module_stock_delivery_sale_section_and_note branch from 364b502 to 9110822 Compare October 17, 2023 13:24
@leemannd
Copy link

Depends on -> OCA/sale-reporting#235
Could you add the dependency (to be able to lauch the tests)?

@StephaneMangin StephaneMangin force-pushed the 15.0_module_stock_delivery_sale_section_and_note branch 3 times, most recently from 0622ffd to 70ada10 Compare October 17, 2023 14:19
@StephaneMangin StephaneMangin force-pushed the 15.0_module_stock_delivery_sale_section_and_note branch from 70ada10 to f506684 Compare October 27, 2023 12:27
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 25, 2024
@leemannd
Copy link

Hello @OCA/logistics-maintainers , your reviews are welcome

@rousseldenis rousseldenis added this to the 15.0 milestone Feb 26, 2024
@rousseldenis
Copy link
Sponsor Contributor

Hi @StephaneMangin could you attend @leemannd comment about temporary reference ?

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

rousseldenis
rousseldenis reviewed Feb 26, 2024
View reviewed changes
stock_delivery_sale_section_and_note/models/stock_move.py
_name = "stock.move"
_inherit = ["stock.move", "display.line.mixin"]

sequence = fields.Integer(related="sale_line_id.sequence", store=True)
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is about this line.

It is highly tight on sale line presence. If the delivery is generated from another flow, how does this behave ?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 7, 2024
@github-actions github-actions bot closed this Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

Assignees
No one assigned
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@StephaneMangin @leemannd @rousseldenis @Ricardoalso