[16.0][ADD] stock_average_daily_sale

[rousseldenis]

Depends on:

• [MIG][16.0] product_abc_classification product-attribute#1192
• [MIG] stock_storage_type: Migration to 16.0 wms#470
• [MIG][16.0] stock_storage_type_putaway_abc wms#496
• [16.0][ADD] product_route_mto product-attribute#1227
• [16.0][ADD] stock_route_mto stock-logistics-warehouse#1580

I've put a comment there : OCA/wms#496 (review)

Because the dependency on stock_storage_type should be avoided

[sbejaoui]

LGTM, thanks

[lmignon]

LGTM (Code review + functiional)

[simahawk]

/ocabot migration stock_average_daily_sale

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[sbejaoui]

@jbaudoux , can you update your review please

[rousseldenis]

@jbaudoux Could you update your review ?

[rousseldenis]

@lmignon Is this really wanted (the code before was closing the new created cursor, not the current one)?

[lmignon]

The code close the new cursor...

cr = registry(self._cr.dbname).cursor()
....

cr.close()

I'll clean the code to improve readability

    @api.model
    def _check_view(self):
        cr = registry(self._cr.dbname).cursor()
        with closing(cr):
            try:
                return self._check_materialize_view_populated(cr)
            except ObjectNotInPrerequisiteState:
                _logger.warning(
                    _("The materialized view has not been populated. Launch the cron.")
                )
                return False
            except Exception as e:
                raise e

[dreispt]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-257-by-dreispt-bump-nobump, awaiting test results.

[OCA-git-bot]

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-257-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[jbaudoux]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-257-by-jbaudoux-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at ef5b108. Thanks a lot for contributing to OCA. ❤️