Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] Make fastapi compatible with python 3.6 #359

Closed

Conversation

moitabenfdz
Copy link

Try to import Annotated from typing (python 3.9+), if import error import Annotated from typing_extensions

Change the pipe operator (|) (python 3.10+) to Union from typing_extensions

Try to import Annotated from typing (python 3.9+), if import error
import Annotated from typing_extensions

Change the pipe operator (|) (python 3.10+) to Union from typing_extensions
@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@lmignon
Copy link
Sponsor Contributor

lmignon commented Jul 10, 2023

Thank you @moitabenfdz for your proposal. Nevertheless we don't want to support py36 for odoo 16. We start with py3.10.

@moitabenfdz
Copy link
Author

Thanks for your reply. My main concern is that doodba16 is in py3. 8.17, therefore, incompatible with fastapi module. I found a TODO task in doodba pull requests from version 16.0 to switch to py3. 10 #525 I'll be glad if @pedrobaeza could give us some information about this, because I would like to use fastapi with doodba.

Thanks for your time, and have a good day!

@pedrobaeza
Copy link
Member

No work has been done yet to use P3.10 as base in Doodba for Odoo v16, as there hasn't been any blocker for now using P3.8. You can try to propose such Python version in Doodba and resolve the few problems related to packages/libraries (or maybe there has already been addressed). My doubt right now is which Python version is Odoo officially using for runbots v16 instances. We like to match with it, as it results battle-tested.

@lmignon
Copy link
Sponsor Contributor

lmignon commented Jul 13, 2023

@pedrobaeza
Copy link
Member

Thanks for the info, Laurent. There's now a PoC to see the problems using that version in Doodba: Tecnativa/doodba#553

@sbidoul sbidoul changed the title [FIX]Make fastapi compatible with python 3.6 [16.0][FIX] Make fastapi compatible with python 3.6 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants