Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] - rest_log #354

Merged
merged 15 commits into from
Dec 12, 2023
Merged

[16.0][MIG] - rest_log #354

merged 15 commits into from
Dec 12, 2023

Conversation

sbejaoui
Copy link
Contributor

No description provided.

@sbejaoui sbejaoui force-pushed the 16.0-rest_log-sbj branch 2 times, most recently from 64e6425 to 86724c7 Compare June 26, 2023 07:32
@lmignon
Copy link
Sponsor Contributor

lmignon commented Jun 26, 2023 •
edited
Loading

@sbejaoui Can you prepare a PR base on this one with the improvements listed below:

These come from https://github.com/acsone/rest-framework/commits/10.0-backport-from-14.0/rest_log

lmignon
lmignon approved these changes Jun 27, 2023
View reviewed changes
Copy link
Sponsor Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review)

@lmignon
Copy link
Sponsor Contributor

lmignon commented Jul 11, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-354-by-lmignon-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 11, 2023
@OCA-git-bot
Merge PR #354 into 16.0
10dd8f9 
Signed-off-by lmignon
@OCA-git-bot
Copy link
Contributor

@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-354-by-lmignon-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@OCA-git-bot
Copy link
Contributor

@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-354-by-lmignon-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sbidoul
Copy link
Member

sbidoul commented Jul 19, 2023

We need to finish #360 to get the 16.0 branch green again.

simahawk
simahawk requested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some fixes: can you please check v14?
AFAIR we made some fix/imp there (the Response obj for instance).

test-requirements.txt Outdated Show resolved Hide resolved
@lmignon
Copy link
Sponsor Contributor

lmignon commented Jul 20, 2023

@sbejaoui Can you include:

@sbejaoui sbejaoui force-pushed the 16.0-rest_log-sbj branch 2 times, most recently from 64ec097 to d7998a4 Compare August 7, 2023 16:38
@sbejaoui sbejaoui requested a review from simahawk August 7, 2023 16:45
@sbejaoui sbejaoui mentioned this pull request Aug 7, 2023
Merged
simahawk and others added 11 commits December 12, 2023 08:57
@simahawk @sbejaoui
rest_log: add sanitize params hook
5a16143 
Provide a hook to customize stored params.
At the same time, assume passwords must be always cleaned up.
@OCA-git-bot @sbejaoui
rest_log 15.0.1.0.1
46979c6
@sbejaoui
[16.0][MIG] - rest_log
126d60d
@lmignon @sbejaoui
[FIX] rest_log: result is not always a json
abda1ab
@sbejaoui
[IMP] rest_log: never crash the call because of the log
cf678f7
@sbejaoui
[IMP] rest_log: do not fail logging because of non-serializable param…
a0d2c2b 
…eters
@lmignon @sbejaoui
[FIX] rest_lot: set the right status on the log in case of error
cb64427
@SilvioC2C @sbejaoui
[FIX] rest_log: fix params management
9dbfa2f
@SilvioC2C @sbejaoui
[IMP] rest_log: refactor headers management
17c6ef2
@SilvioC2C @sbejaoui
[IMP] rest_log: handle odoo.http.Response objects in logs
a275c69 
Some endpoints will not return a dict as expected by the ``_dispatch_with_db_logging`` method (and the other methods called within), but an object of type ``odoo.http.Response``.
When that happens, the instance fails to handle it while creating logs (ie: tries to call ``json.dumps()`` on such object, which is not allowed).
This patch should fix the issue.
@simahawk @sbejaoui
rest_log: add hook to customize result
b2fc4d7
@lmignon
Copy link
Sponsor Contributor

lmignon commented Dec 12, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-354-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 12, 2023
@OCA-git-bot
Merge PR #354 into 16.0
7adaab5 
Signed-off-by lmignon
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-354-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1f7505a into OCA:16.0 Dec 12, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 883c8fb. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-rest_log-sbj branch December 12, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@simahawk simahawk Awaiting requested review from simahawk

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sbejaoui @lmignon @OCA-git-bot @sbidoul @simahawk @SilvioC2C