Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][IMP] l10n_es_extra_data: Nuevos impuestos no soportados por Odoo Oficial #3734

Open
wants to merge 1 commit into
base: 12.0
Choose a base branch
from
Open

[12.0][IMP] l10n_es_extra_data: Nuevos impuestos no soportados por Odoo Oficial #3734

wants to merge 1 commit into from
+663 −7

Conversation

mpascuall
Copy link
Contributor

@mpascuall mpascuall commented Sep 26, 2024 •
edited
Loading

Buenas @acysos !
Hemos adaptado tu PR #3733 para que pueda ser usado en la versión 12.
Si tienes un momento podrías revisarlo?
Gracias de antemano y saludos.

@OCA-git-bot
Copy link
Contributor

Hi @cubells,
some modules you are maintaining are being modified, check this out!

@acysos
Copy link
Member

acysos commented Sep 27, 2024

Veo que en el último commit habéis corregido los campos de los data. Estaban con campos de la 13.0 no de la 12.0. Te faltaría el tema de los archivos README

@acysos acysos self-requested a review September 27, 2024 10:17
acysos
acysos requested changes Sep 27, 2024
View reviewed changes
l10n_es_extra_data/README.rst Outdated
|badge1| |badge2| |badge3| |badge4| |badge5|
.. |badge3| image:: https://img.shields.io/badge/github-APSL%2Fcustom-lightgray.png?logo=github
:target: https://github.com/APSL/custom/tree/16.0/l10n_es_extra_data
:alt: APSL/custom
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto es incorrecto, debería ser OCA, de hecho no debería cambiar la documentación más allá de los contributos o que se añade los impuestos nuevos.

l10n_es_extra_data/README.rst Outdated
@@ -76,10 +70,10 @@ En posteriores versiones se renombran de la siguiente manera:
Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/l10n-spain/issues>`_.
Bugs are tracked on `GitHub Issues <https://github.com/APSL/custom/issues>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Los mismo, me temo que habéis hecho un replace

l10n_es_extra_data/README.rst Outdated
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_extra_data%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
`feedback <https://github.com/APSL/custom/issues/new?body=module:%20l10n_es_extra_data%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Igual que antes OCA no ASPL

l10n_es_extra_data/README.rst
~~~~~~~~~~~

This module is maintained by the OCA.
* `APSL - Nagarro <https://apsl.tech>`__:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debería ser contributor

l10n_es_extra_data/README.rst Outdated

.. image:: https://odoo-community.org/logo.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No se puede eliminar a OCA

l10n_es_extra_data/static/description/index.html
@@ -301,7 +301,7 @@
span.pre {
white-space: pre }

span.problematic {
span.problematic, pre.problematic {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Este cambio no es necesario

l10n_es_extra_data/static/description/index.html Outdated
@@ -427,10 +427,10 @@ <h2><a class="toc-backref" href="#toc-entry-4">12.0.1.0.0 (2022-07-20)</a></h2>
</div>
<div class="section" id="bug-tracker">
<h1><a class="toc-backref" href="#toc-entry-5">Bug Tracker</a></h1>
<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/l10n-spain/issues">GitHub Issues</a>.
<p>Bugs are tracked on <a class="reference external" href="https://github.com/APSL/custom/issues">GitHub Issues</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Igual que antes OCA no ASPL

l10n_es_extra_data/static/description/index.html Outdated
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
<a class="reference external" href="https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_extra_data%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<a class="reference external" href="https://github.com/APSL/custom/issues/new?body=module:%20l10n_es_extra_data%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Igual que antes OCA no ASPL

l10n_es_extra_data/static/description/index.html Outdated
mission is to support the collaborative development of Odoo features and
promote its widespread use.</p>
<p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
<p>Current maintainer:</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No se puede quitar OCA

l10n_es_extra_data/static/description/index.html Outdated
<p><a class="reference external image-reference" href="https://github.com/cubells"><img alt="cubells" src="https://github.com/cubells.png?size=40px" /></a></p>
<p>This module is part of the <a class="reference external" href="https://github.com/OCA/l10n-spain/tree/12.0/l10n_es_extra_data">OCA/l10n-spain</a> project on GitHub.</p>
<p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
<p>This module is part of the <a class="reference external" href="https://github.com/APSL/custom/tree/16.0/l10n_es_extra_data">APSL/custom</a> project on GitHub.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Igual que antes OCA no ASPL

@pedrobaeza
Copy link
Member

Estoy viendo que dados los cambios en el modelo 303, la mejor estrategia sería renombrar los otros impuestos y cambiar su porcentaje.

@BernatObrador
Copy link

BernatObrador commented Sep 27, 2024 •
edited
Loading

¡Hola @acysos! Gracias por tu aportación.
Ya está cambiado el readme, se ve que el pre-commit estaba mal configurado.

@pedrobaeza pedrobaeza changed the title [IMP] l10n_es_extra_data: Nuevos impuestos no soportados por Odoo Oficial [12.0][IMP] l10n_es_extra_data: Nuevos impuestos no soportados por Odoo Oficial Sep 27, 2024
@miquelalzanillas
Copy link
Contributor

Hola @pedrobaeza ,

te refieres a actualizar el porcentaje del impuesto existente del 0% al 2.5%?

Si es así, no estaríamos modificando el porcentaje de impuestos ya relacionados con apuntes antiguos?

Disculpa, pero no sé si te he entendido.

@pedrobaeza
Copy link
Member

Sí, me refería a eso. Realmente, el porcentaje ya estaría aplicado en esos apuntes, pero es cierto que cualquier modificación, te lo descabalaría. Nada, olvídalo. Hablando con @acysos también por chat lo hemos descartado por otros efectos laterales como reimprimir un ticket POS.

@pedrobaeza pedrobaeza added this to the 12.0 milestone Sep 27, 2024
@miquelalzanillas
Copy link
Contributor

Exacto. Pues seguimos por esta vía. Gracias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acysos acysos acysos requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mpascuall @OCA-git-bot @acysos @pedrobaeza @BernatObrador @miquelalzanillas