Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] l10n_es_pos_sii: Set own channel for POS order SII jobs #3717

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[16.0][FIX] l10n_es_pos_sii: Set own channel for POS order SII jobs #3717

merged 1 commit into from
Sep 16, 2024

Conversation

aritzolea
Copy link
Contributor

@aritzolea aritzolea commented Sep 11, 2024 •
edited
Loading

Se crea un nuevo canal para los trabajos de envíos de los pedidos de TPV

@aritzolea
Copy link
Contributor Author

@zamberjo podrías revisar esto? Gracias

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 11, 2024
@pedrobaeza
Copy link
Member

¿Por qué un canal específico? Esto no es retro-compatible para las instancias existentes, que dejarían de tener la configuración correspondiente.

@aritzolea
Copy link
Contributor Author

¿Por qué un canal específico? Esto no es retro-compatible para las instancias existentes, que dejarían de tener la configuración correspondiente.

Se ha especificado un canal específico porque los trabajos se estaban creando en el canal root. Por otra parte, hemos pensado no utilizar el canal root.invoice_validate_sii que se utiliza para las facturas para poder controlar el flujo de forma independiente.

@aritzolea aritzolea marked this pull request as ready for review September 11, 2024 11:36
@pedrobaeza
Copy link
Member

OK, entendido entonces. En ese caso, entiendo que sí habría retrocompatibilidad, y no me parece mal el cambio.

zamberjo
zamberjo reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@zamberjo zamberjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@almumu ¿Cómo lo ves?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@aritzolea
Copy link
Contributor Author

@pedrobaeza Se puede mergear?

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3717-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d528258 into OCA:16.0 Sep 16, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e073168. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zamberjo zamberjo zamberjo left review comments

@danielduqma danielduqma danielduqma approved these changes

@almumu almumu almumu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@aritzolea @pedrobaeza @OCA-git-bot @zamberjo @danielduqma @almumu