[17.0][ADD] hr_attendance_ip_check #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemannd
reviewed
Jul 1, 2024
|
|
||
| @api.constrains("check_in", "check_out", "employee_id") | ||
| def _check_validity(self): | ||
| self.employee_id._attendance_ip_check() |
There was a problem hiding this comment.
Isn't self a recordset and therefore you should loop on self?
leemannd
reviewed
Jul 1, 2024
|
|
||
| from odoo import _, exceptions, fields, models | ||
| from odoo.http import request | ||
|
|
There was a problem hiding this comment.
Suggested change
| from odoo.tools import config | |
leemannd
reviewed
Jul 1, 2024
|
|
||
| def _attendance_ip_check(self): | ||
| """Return if client ip is not in totp cidrs.""" | ||
| test_enable = self.env.context.get("test_enable") |
There was a problem hiding this comment.
Suggested change
| test_enable = self.env.context.get("test_enable") | |
| test_enable = config["test_enable"] |
I'm more used to have it from config
leemannd
reviewed
Jul 1, 2024
|
|
||
| attendance_cidr_ids = fields.Many2many("attendance.cidr", ondelete="restrict") | ||
|
|
||
| def _attendance_ip_check(self): |
There was a problem hiding this comment.
When called this method is doing several calls on self but it can be a recordset and will lead to failures
There was a problem hiding this comment.
Branch updated, please check again
sonhd91
force-pushed
the
17.0-mig-hr_attendance_ip_check
branch
2 times, most recently
from
8c1a764
to
554f657
Compare
leemannd
approved these changes
Aug 13, 2024
sonhd91
force-pushed
the
17.0-mig-hr_attendance_ip_check
branch
from
554f657
to
1e3be03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.