Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] hr_attendance_reason: Show reasons on attendance screen #124

Merged
merged 3 commits into from
Jul 4, 2023
Merged

[15.0][IMP] hr_attendance_reason: Show reasons on attendance screen #124

merged 3 commits into from
Jul 4, 2023

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Apr 28, 2023 •
edited
Loading

FWP from 14.0: #102 + #123 + #125

Show reasons on attendance screen.
ejemplo

@Tecnativa TT40897

@pedrobaeza pedrobaeza added this to the 15.0 milestone Apr 28, 2023
@pedrobaeza
Copy link
Member

You can squash 3 first commits IMO.

@victoralmau victoralmau force-pushed the 15.0-imp-hr_attendance_reason-kiosk branch 2 times, most recently from b5c6fb6 to e377ca8 Compare May 4, 2023 10:52
@victoralmau victoralmau force-pushed the 15.0-imp-hr_attendance_reason-kiosk branch from ce71c60 to 1556832 Compare June 21, 2023 14:53
@victoralmau victoralmau marked this pull request as ready for review June 21, 2023 14:54
@victoralmau
Copy link
Member Author

Now, you are ready to review. My tests everything works correctly.

@victoralmau victoralmau changed the title [15.0][WIP] hr_attendance_reason: Show reasons on attendance screen [15.0][IMP] hr_attendance_reason: Show reasons on attendance screen Jul 3, 2023
@victoralmau
Copy link
Member Author

Ping @chienandalu

@victoralmau victoralmau force-pushed the 15.0-imp-hr_attendance_reason-kiosk branch from 1556832 to 4399b6a Compare July 3, 2023 10:51
@victoralmau
[IMP] hr_attendance_reason: Rename show_reasons_on_attendance_screen …
2b77bf2 
…field to show_reason_on_attendance_screen

TT40897
@victoralmau
Copy link
Member Author

Changes done.

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-124-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d8a071e into OCA:15.0 Jul 4, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9c4991a. Thanks a lot for contributing to OCA. ❤️

@victoralmau victoralmau mentioned this pull request Jul 5, 2023
Merged
@pedrobaeza pedrobaeza deleted the 15.0-imp-hr_attendance_reason-kiosk branch July 5, 2023 06:36
This was referenced Jul 5, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @chienandalu