Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_payment_return_import_iso20022: Migration to 17.0 #755

Merged

Conversation

carolinafernandez-tecnativa
  • Standard migration to v17

@Tecnativa
TT49284

@pedrobaeza @carlos-lopez-tecnativa

@pedrobaeza
Copy link
Member

/ocabot migration account_payment_return_import_iso20022

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 29, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 29, 2024
10 tasks
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlos-lopez-tecnativa
Copy link

@carolinafernandez-tecnativa Please update the latest commit; the dependency has now been merged. #752

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 17.0-mig-account_payment_return_import_iso20022 branch from 207305e to 5c32d8a Compare July 31, 2024 16:26
@carolinafernandez-tecnativa
Copy link
Author

@carolinafernandez-tecnativa Please update the latest commit; the dependency has now been merged. #752

done~

@carlos-lopez-tecnativa
Copy link

carlos-lopez-tecnativa commented Jul 31, 2024

@carolinafernandez-tecnativa Please update the latest commit; the dependency has now been merged. #752

done~

@carolinafernandez-tecnativa, sorry for the confusion. I initially thought this module depended on account_payment_return, but it actually depends on account_payment_return_import, which has not been merged yet. Please update the PR description to add the dependency and avoid confusion. Also, add the dependency again. Sorry for the mix-up.

image

ThomasBinsfeld and others added 19 commits August 26, 2024 13:23
* [ADD] Account Payment Return Import CAMT: parser camt.054.001.02 files

* [REF] Account Payment Return Import ISO20022: merge the two iso20022 modules in one

* [REF] Account Payment Return Import: use SavepointCase instead of TransactionCase

* [REF] Increase global code coverage

[UPD] Update account_payment_return_import_iso20022.pot
Known issue in BNP France payment return files
…nd details nodes

There may be more than one notification node in a single document and
there may be more than one details node in a single entry node.
Each entry node must create a single payment return.
Each details node must create a payment return line.
The return amount must be taken in the details node instead on the entry node.

Document
  |
  |--> Notification Node
  |     |
  |     |--> Entry Node
  |     |     |
  |     |     |-> Details Node
  |     |     |-> Details Node
  |     |     |-> ...
  |     |
  |     |--> Entry Node
  |     |     |
  |     |     |-> Details Node
  |     |     |-> ...
  |     |
  |     |--> ...
  |
  |--> Notification Node (...)
  |
  |--> ...
missing quotes in L216 and 217 to escape comma used in name
[UPD] Update account_payment_return_import_iso20022.pot

account_payment_return_import_iso20022 12.0.1.1.0

[UPD] README.rst
[UPD] Update account_payment_return_import_iso20022.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-payment-13.0/account-payment-13.0-account_payment_return_import_iso20022
Translate-URL: https://translation.odoo-community.org/projects/account-payment-13-0/account-payment-13-0-account_payment_return_import_iso20022/
TT30247

[UPD] Update account_payment_return_import_iso20022.pot

[UPD] README.rst
… return and set partner. fix OCA#581

account_payment_return_import_iso20022 14.0.2.0.1
Currently translated at 56.4% (127 of 225 strings)

Translation: account-payment-16.0/account-payment-16.0-account_payment_return_import_iso20022
Translate-URL: https://translation.odoo-community.org/projects/account-payment-16-0/account-payment-16-0-account_payment_return_import_iso20022/es/
…ement

- Include context keys for avoiding mail operations overhead.
@pedrobaeza pedrobaeza force-pushed the 17.0-mig-account_payment_return_import_iso20022 branch from 5c32d8a to ffc9bd4 Compare August 26, 2024 11:23
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-755-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 828c9db into OCA:17.0 Aug 26, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b42d5e6. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-account_payment_return_import_iso20022 branch August 26, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.