[16.0][MIG] account_payment_credit_card: Migration to version 16.0 #751
Conversation
The expected signature is _post(soft=True)
this commit avoid error unbalanced journal add context skip_account_move_synchronization for skip exception on https://github.com/odoo/odoo/blob/2851f3b5a7caf3530777071a3641ed00ea264ced/addons/account/models/account_payment.py#L709
|
@carolinafernandez-tecnativa @pedrobaeza could you please help me with the review of this module? Thank you! |
There was a problem hiding this comment.
Check this example:
I registered payment to this invoice with journal configuration
Payment is created correctly, but invoice still pending to paid and let me add many payments...
If you test it with the same partner as set in journal, it happens the same.
Is this behavoiur is on the goal of this module?
Journal configuration:
|
@carolinafernandez-tecnativa I noticed that you tested with a Please test with vendor bills. @pedrobaeza, could you provide your comments on whether we need to add a constraint to prevent usage with customer invoices? With vendor bills, it works fine for me. |
|
Ok, please check with customer invoices is making an unusual behavour that was my intention to transmit for journal that has the configuration. Maybe add a restriction not to use this journal to pay customer invoices. |
carlos-lopez-tecnativa
force-pushed
the
16.0-mig-account_payment_credit_card
branch
from
621053e
to
41f2c0c
Compare
Yes, this behavior has been inconsistent since version 14 (it only worked for vendor bills). @pedrobaeza, should we add this restriction as part of the migration, or should we not add the constraint? |
|
/ocabot migration account_payment_credit_card I don't think we should restrict them, as there can be legit debits in these journals. The README is clear stating about vendor bills, so nothing more to be done on your side. |
|
This PR has the |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at e7b093e. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa TT49796