Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: skip some TLS tests on 20.x and 18.x #344086

Draft
wants to merge 1 commit into
base: staging-next
Choose a base branch
from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 23, 2024

Addresses #343421 (comment).

It looks like some tests are only passing on 22.x branch atm, I wasn't able to pin point any obvious commit that address this issue, I guess it's fine to skip those tests for now to unblock the build.

@aduh95
Copy link
Contributor Author

aduh95 commented Sep 23, 2024

(Having just say that, I realize that it might be nodejs/node@01f751b that I somehow missed. I can't really test that hypothesis as there are simply too much stuff to rebuild, once the caches have been populated I'll try to see if the tests pass with that commit applied)

@fabianhjr
Copy link
Member

fabianhjr commented Sep 24, 2024

once the caches have been populated I'll try to see if the tests pass with that commit applied

afaik that change will make every dependent rebuild anyways. If these tests are disabled I would push for them to only be re-enabled until the next staging-next cycle to avoid wasting resources/compute doing 5k rebuilds per platform. (Including big packages like web engines)

Edit: Misunderstood the cache the other way around, leaving as draft while the dependencies of nodejs are built to avoid this being merged before you have a chance to test the potential patch.

@fabianhjr fabianhjr marked this pull request as draft September 24, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants