dotnet: split sdk packages by platform #343837
Open
+2,632
−1,994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corngood
force-pushed
the
dotnet-sdk-packages
branch
from
15dac4d
to
0ee97cf
Compare
|
Result of 135 packages built:
|
corngood
force-pushed
the
dotnet-sdk-packages
branch
from
0ee97cf
to
170955e
Compare
|
Result of 9 packages marked as broken and skipped:
78 packages built:
|
ofborg
bot
requested review from
konradmalik,
TomaSajt,
SuperSandro2000,
purcell,
tie,
kuznero and
mdarocha
corngood
force-pushed
the
dotnet-sdk-packages
branch
from
170955e
to
5bda956
Compare
GGG-KILLER
approved these changes
Sep 23, 2024
konradmalik
approved these changes
Sep 23, 2024
corngood
force-pushed
the
dotnet-sdk-packages
branch
from
5bda956
to
717c57f
Compare
konradmalik
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The primary change here is to make
dotnet-sdk.packagescontain only the packages needed for the host/target systems. This should help address #337030. The other target packages are available indotnet-sdk.targetPackages.${rid}should they be needed (e.g. for fetch-deps).For VMR (source-built sdk/runtime), we can't currently cross-compile packages for the other RIDs, so we pass through the binary packages for the other RIDs. Previously, the VMR
sdk.packagesonly contained target packages for a single RID. This means it should now be usable as a drop-in replacement for the same version of the binary SDK.There are some package fixes in here that give an idea of the sort of breaking changes this could cause. Mostly it's just packages that were unnecessarily restoring for multiple RIDs.
Cc: @NixOS/dotnet
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.