tacentview: init at 1.0.46 #341239
Open
tacentview: init at 1.0.46 #341239
+107
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonTorres
suggested changes
Sep 23, 2024
pkgs/by-name/ta/tacent/package.nix
Outdated
| homepage = "https://github.com/bluescan/tacent"; | ||
| license = lib.licenses.isc; | ||
| maintainers = [ lib.maintainers.PopeRigby ]; | ||
| platforms = [ lib.platforms.linux ]; |
There was a problem hiding this comment.
I believe so. It makes no mention of MacOS support.
There was a problem hiding this comment.
The source code has some macos-related macros.
Comment on lines
+39
to
+42
| "-DFETCHCONTENT_SOURCE_DIR_TACENT=${tacent.src}" | ||
| "-DPACKAGE_NIX=True" |
There was a problem hiding this comment.
Suggested change
| "-DFETCHCONTENT_SOURCE_DIR_TACENT=${tacent.src}" | |
| "-DPACKAGE_NIX=True" | |
| (lib.cmakeFeature "FETCHCONTENT_SOURCE_DIR_TACENT" "${tacent.src}") | |
| (lib.cmakeBool "PACKAGE_NIX" true) |
There was a problem hiding this comment.
Is this necessary? I didn't see any other packages using it.
There was a problem hiding this comment.
A simple rg --type=nix cmakeBool returns more than 400 results in pkgs/by-name.
Further, lib.cmake* functions type-checks their arguments.
ofborg
bot
added
8.has: package (new)
11.by: package-maintainer
10.rebuild-linux: 1-10
and removed
10.rebuild-linux: 0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I've added both Tacent View (an application for viewing various image formats), and the library it depends on, Tacent.
Closes #219830
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.