Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mosquitto: fix "listeners" option default #333317

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Aug 8, 2024

Description of changes

The option type is listOf, so the default should be an empty list, not
empty attrset.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The option type is listOf, so the default should be an empty list, not
empty attrset.
@Mindavi Mindavi merged commit 8c6460b into NixOS:master Aug 9, 2024
26 checks passed
@bjornfor bjornfor deleted the nixos-mosquitto-fix-option-default branch August 9, 2024 07:08
@bjornfor bjornfor added the backport release-24.05 Backport PR automatically label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants