nushellPlugins.dbus: init at 0.10.0 #333053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkKronicle
force-pushed
the
init-nushellplugin-dbus
branch
from
703b2a3
to
195fde5
Compare
tobim
approved these changes
Aug 8, 2024
|
I'm not sure if this will build on darwin (from what I can tell dbus should at least work on Mac?). Other than that, all other plugins had some sort of added dependency for darwin. Does anyone know about that? I can also wait a few more days for OfBorg to finish. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4433 |
DarkKronicle
force-pushed
the
init-nushellplugin-dbus
branch
from
195fde5
to
a32dade
Compare
DarkKronicle
force-pushed
the
init-nushellplugin-dbus
branch
from
78db28d
to
bd5f236
Compare
DarkKronicle
changed the title
DarkKronicle
force-pushed
the
init-nushellplugin-dbus
branch
from
bd5f236
to
0aeeca6
Compare
|
Rebased and updated to use the newer nushell version. EDIT: looks like it all builds now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add nu_plugin_dbus
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.