[Backport release-24.05] albert: 0.24.1 -> 0.25.0 #333032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2d06eed)
This is more robust and automatic to check if the file still exists in the same location and if we can still replace the string. (cherry picked from commit 532ba73)
This release fixes the issue where users can no longer search for Application queries (possibly others) if they have fuzzy search toggled for it (cherry picked from commit d563ec9)
|
I rebased because there was some conflict with the description and I changed the version to to 0.24.1 because it's the current stable, while the PR we're backporting is from 0.24.3. The CI says is's not a hard fail, so is this fine or should I cherry-pick all the preceding commits as well? |
marcusramberg
approved these changes
Aug 7, 2024
|
Alright, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This release fixes the issue where users can no longer search for Application queries (possibly others) if they have fuzzy search toggled for it.
Manual backport of #331719
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.