Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch ct.CanteraError when the cvodes integrator fails in sensitivity analysis #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xMestas
Copy link
Contributor

@xMestas xMestas commented Aug 21, 2019

Fixes #64

@xMestas xMestas added the bug label Aug 21, 2019
@xMestas xMestas self-assigned this Aug 21, 2019
@codecov-io
Copy link

codecov-io commented Aug 21, 2019

Codecov Report

Merging #65 into master will decrease coverage by 0.13%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   66.98%   66.85%   -0.14%     
==========================================
  Files          12       12              
  Lines        1266     1270       +4     
  Branches      294      294              
==========================================
+ Hits          848      849       +1     
- Misses        316      319       +3     
  Partials      102      102
Impacted Files Coverage Δ
pymars/sensitivity_analysis.py 70.58% <40%> (-2.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aace7af...992a85a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sensitivity analysis crashes when important species are in limbo
2 participants