[POC][cli-options-from-step-decorators][WIP] #1985
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two parts to this whole change: > How do step decorators inject CLI parameters - This part is handled by piggy backing on the `flow_context` to inject the unique steps decorators in the code. - Once the unique step decorators are available via the `current_flow` local variable, we can extract all the options a decorator class exposes and then inject them into the CLI based on the kind/type of CLI we need to inject it into. > How are the injected parameters passed down to the decorators. - Current TBD - Needs more discussion to decide what needs to happen here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two parts to this whole change:
flow_contextto inject the unique steps decorators in the code.current_flowlocal variable, we can extract all the options a decorator class exposes and then inject them into the CLI based on the kind/type of CLI we need to inject it into.