Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAC Catalog Functionality #184

Merged
merged 12 commits into from
Mar 27, 2024
Merged

STAC Catalog Functionality #184

merged 12 commits into from
Mar 27, 2024

Conversation

GregoryPetrochenkov-NOAA
Copy link
Collaborator

@GregoryPetrochenkov-NOAA GregoryPetrochenkov-NOAA commented Feb 8, 2024

This PR addresses #183 as well as bug fixes for attribute tracking and tabulation pairing dictionary attributes.

Changes

  • gval_xarray.py: Address issue with attribute_tracking names
  • tabulationpy: Address issue with pairing_dictionary attributes in tabulation
  • loading_datasets.py: Refactor query STAC function, and implement STAC query to catalog DataFrame
  • cases_catalogs.py: Add test cases for STAC catalog comparisons
  • test_catalogs.py: Add tests for STAC catalog comparisons
  • pyproject.toml: Update version

Copy link
Member

@fernando-aristizabal fernando-aristizabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Removed]

src/gval/comparison/tabulation.py Show resolved Hide resolved
src/gval/utils/loading_datasets.py Outdated Show resolved Hide resolved
src/gval/utils/loading_datasets.py Outdated Show resolved Hide resolved
src/gval/utils/loading_datasets.py Show resolved Hide resolved
src/gval/utils/loading_datasets.py Outdated Show resolved Hide resolved
src/gval/utils/loading_datasets.py Outdated Show resolved Hide resolved
src/gval/utils/loading_datasets.py Outdated Show resolved Hide resolved
src/gval/utils/loading_datasets.py Outdated Show resolved Hide resolved
src/gval/utils/loading_datasets.py Show resolved Hide resolved
src/gval/utils/loading_datasets.py Outdated Show resolved Hide resolved
@fernando-aristizabal fernando-aristizabal marked this pull request as draft February 29, 2024 16:49
@GregoryPetrochenkov-NOAA GregoryPetrochenkov-NOAA marked this pull request as ready for review February 29, 2024 17:47
@fernando-aristizabal fernando-aristizabal changed the title STAC Catalog Funcitonality STAC Catalog Functionality Feb 29, 2024
src/gval/utils/loading_datasets.py Outdated Show resolved Hide resolved
src/gval/utils/loading_datasets.py Outdated Show resolved Hide resolved
src/gval/utils/loading_datasets.py Show resolved Hide resolved
src/gval/utils/loading_datasets.py Show resolved Hide resolved
src/gval/utils/loading_datasets.py Outdated Show resolved Hide resolved
tests/cases_catalogs.py Show resolved Hide resolved
src/gval/utils/loading_datasets.py Show resolved Hide resolved
src/gval/utils/loading_datasets.py Outdated Show resolved Hide resolved
src/gval/utils/loading_datasets.py Show resolved Hide resolved
src/gval/utils/loading_datasets.py Show resolved Hide resolved
@@ -219,3 +221,88 @@ def test_compare_catalogs_fail(
open_kwargs=open_kwargs,
agreement_map_field=agreement_map_field,
)


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see it come together

@fernando-aristizabal fernando-aristizabal merged commit 9d5bc26 into main Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants