Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attr tracking #142

Merged
merged 9 commits into from
Jul 26, 2023
Merged

Attr tracking #142

merged 9 commits into from
Jul 26, 2023

Conversation

fernando-aristizabal
Copy link
Member

Closes #132

  • Implements within file attribute tracking.
  • Tags raster attributes from candidate and benchmark to an attributes df along with agreement map.
  • Uses attributes df schema
  • Implements tests.
  • Creates attribute tracking accessor method.
  • Implements attribute tracking within continuous and categorical compare accessor methods.

@fernando-aristizabal
Refers to #132 attribute tracking
f4fe8f4 
- started private function for within file attr tracking
- initiated attribute df schema
- created a new base schema for columns method
- started testing scripts but still pending
@fernando-aristizabal
updated testing. Not ready
ed3ad38
@fernando-aristizabal
Merge branch 'main' into attr_tracking
5227606
@fernando-aristizabal
passing tests
1dc8b92
@fernando-aristizabal
minor clean
ac4a8cd
@fernando-aristizabal
Closes #132 attribute tracking
2cb1b0d 
- implements attribute tracking abilities within accessor method
- implements tracking within categorical and continuous compare methods
- implements tests for features
@fernando-aristizabal fernando-aristizabal added the enhancement New feature or request label Jul 24, 2023
@fernando-aristizabal fernando-aristizabal added this to the End of FY milestone Jul 24, 2023
@fernando-aristizabal fernando-aristizabal self-assigned this Jul 24, 2023
@fernando-aristizabal
Copy link
Member Author

Made some changes as apparently it wasn't passing linting. Great use of automation!

@fernando-aristizabal
Copy link
Member Author

Ready to review @GregoryPetrochenkov-NOAA pending successful CI builds and tests.

@GregoryPetrochenkov-NOAA GregoryPetrochenkov-NOAA merged commit f121ad5 into main Jul 26, 2023
4 checks passed
@GregoryPetrochenkov-NOAA GregoryPetrochenkov-NOAA deleted the attr_tracking branch July 26, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryPetrochenkov-NOAA GregoryPetrochenkov-NOAA GregoryPetrochenkov-NOAA approved these changes

Assignees

@fernando-aristizabal fernando-aristizabal

Labels
enhancement New feature or request
Projects
None yet
Milestone
End of FY
Development

Successfully merging this pull request may close these issues.

Within-File Attribute Tracking
2 participants
@fernando-aristizabal @GregoryPetrochenkov-NOAA