Refactorings #209
Open
Refactorings #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development
Apply syntax highlighting to bibtex in README.md
…tional dependency
medaCy 1.0.1
Need to look into how to modularize tests with pytest, as I assume this system is not idiomatic.
|
Closes #208. |
Use list comprehensions where appropriate; uncouple a `zip` instance that could have been two list comps; flatten nested logic where possible.
As it turns out, the numbering did start at 0 after all.
|
Closes #210 |
bmcinnes
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a couple of non-spec changes to the BiLSTM and BERT code while doing a code exploration. Only one is intended to boost performance.
I also migrated the tests related to the refactored functionality to pytest, marked those tests as slow, and instructed Travis not to run slow tests. We might consider migrating the whole test suite to pytest.