Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove singular check for LU decomposition and add const qualifier to the CUDA kernels #671

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sjsprecious
Copy link
Collaborator

This PR:

  • removes the singular check for LU decomposition (previously the GPU code is not checking the singularity correctly).
  • adds the const qualifier to the CUDA kernels (it reduces the time of 64 tests (including all CUDA tests) to 245 seconds now!)

fix #664
fix #637

@sjsprecious sjsprecious self-assigned this Sep 27, 2024
@sjsprecious sjsprecious added the enhancement New feature or request label Sep 27, 2024
@sjsprecious sjsprecious added this to the CUDA Rosenbrock Solver milestone Sep 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.35%. Comparing base (c756a3d) to head (cc70d62).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   93.33%   93.35%   +0.02%     
==========================================
  Files          53       53              
  Lines        3603     3569      -34     
==========================================
- Hits         3363     3332      -31     
+ Misses        240      237       -3     
Flag Coverage Δ
93.35% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants