Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing irrelevant cmake tests #556

Merged
merged 1 commit into from
Jun 5, 2024
Merged

removing irrelevant cmake tests #556

merged 1 commit into from
Jun 5, 2024

Conversation

K20shores
Copy link
Collaborator

I feel like these tests don't do anything for us and we should remove them. What do y'all think? We inherently test that we can use fetch content by using it in musica

Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (555be4e) to head (3cc3af2).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          45       45           
  Lines        3407     3407           
=======================================
  Hits         3143     3143           
  Misses        264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjsprecious sjsprecious merged commit f538a60 into main Jun 5, 2024
32 checks passed
@sjsprecious sjsprecious deleted the removing_cmake_tests branch June 5, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants