-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline files #206
Add inline files #206
Conversation
I like this. It does seem easier to read with the function definitions in a separate file, kind of like normal |
The projects I've seen that maintain header-only library with additional inline files seem to put them in the same directory but I think we could put them in the separate directory such as |
That sounds good to me - let's keep the |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 28 29 +1
Lines 2427 2428 +1
=======================================
+ Hits 2359 2360 +1
Misses 68 68
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
Solver class has numerical implementation details that could be separated from the interface which makes the header files a little easier to read. There are two files that I worked on as a demo to discuss whether to have
inl
(inline) files separated from its header files.