Rebase/main into develop fa1802a #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion fixes and reorganization of running documentation files
…ation Derecho MkDocs Documentation
Added an ability to limit the maximum relative humidity in the forcing data (e.g set parameter rh_limit=1.2) Fixed possible pressure interpolation bug and generally improved pressure interpolation process significantly (note this can change precip) Cleanup some commented sections and changed more print* values to write(*,*) if they seemed permanent
…cipitation rate and minimum input SST value
…hen using one vs. multiple processes. Lat and long fields are copied to global variables until costheta and sintheta are calculated. Slight change to that calculation has been made.
…s -hfp1 (i.s.o standard -hfp2). This seems to prevent floating errors in NoahMP due to floating point precision/optimization.
…ates if SLEVE=True in nml
… diagnostic error only, did not have effect on model results.
…o to a monthly perscribed value
…when there are too many)
…aking the numerics
… as global attribute, first time uninitialized
…to fix an n-cores difference that occurs because the halo cell from the diagonal image is needed for correct calculations. Currently the whole u,v halos are exchanged instead of just the diagonal cell because of a bug within gfortran or opencoarrays that accesses the wrong memory when indexing a subarray of a coarray on a different image
…. n/s then e/w communication instead of doing all halo communication twice.
… type variable. Previous behavior meant the value used by the last grid to set halo_size was used for every exchangeable object going forward. 2. wind=1 physics option was failing n-cores test due to smoothing behavior. New larger exchange_obj variable used to cover the extra area needed for the smooth function to pass n-cores tests. Possibly can be reused other places if smoothing is causing issues
…smooth value it its calculations, fixing to the correct value
… check, when the namelist is read, the existense of the directories where the output and restart files are being written to. If they do not exist routine will report error then, rather than throwing an error later when the netcdf library tries to write to the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: current procedure is to make changes to the develop branch and create pull requests into the develop branch. When making this Pull Reqest make sure to change the base branch to "develop".
Use this template to give a detailed message describing the change you want to
make to the code.
The title of this pull request should be a brief "purpose" for this change.
--- Delete this line and those above before hitting "Create pull request" ---
TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no
impact, text only]
KEYWORDS: approximately 3 to 6 words (more is always better) related to your
commit, separated by commas
SOURCE: Developer's name and affiliation
DESCRIPTION OF CHANGES: One or more paragraphs describing problem, solution,
and required changes.
ISSUE: The GitHub Issue that this PR addresses. For issue number 123, it would
be
Fixes #123TESTS CONDUCTED: Explicitly state if regression, integration, or unit tests
were run before submitting (do not include the CI tests automatically run by
GitHub)
NOTES: Optional, as appropriate. Delete if not used. Included only once for
new features requiring several merge cycles. Changes to default behavior are
also note worthy.
Checklist
Merging the PR depends on following checklist being completed. Add
Xbetweeneach of the square brackets if they are completed in the PR itself. If a
bullet is not relevant to you, please comment on why below the bullet.
issue describes and documents the problem and general solution, the PR
describes the technical details of the solution.)