Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request Form in Issue Template #623

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feature Request Form in Issue Template #623

wants to merge 4 commits into from

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented May 23, 2024 •
edited
Loading

PR Summary

Add link to Feature Request Form in Issue Template

Related Tickets & Documents

Closes #622

PR Checklist

General

  • PR includes a summary of changes
  • Link relevant issues, make one if none exist
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the upcoming release.
  • Add appropriate labels to this PR
  • PR follows the Contributor's Guide

@cyschneck cyschneck added documentation Improvements or additions to documentation developer feature For development standardization / best practices / enhancement labels May 23, 2024
@cyschneck cyschneck self-assigned this May 23, 2024
@anissa111
Copy link
Member

Thanks for being so quick on this!

What if we did something like this, so that the form is presented at the same time as the other issue templates?

To see it used, look at xarray's issue template config.yml and how it looks live on their new issue page

@cyschneck cyschneck marked this pull request as ready for review May 23, 2024 21:55
@cyschneck cyschneck requested a review from anissa111 May 23, 2024 21:55
anissa111
anissa111 reviewed May 23, 2024
View reviewed changes
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo catch, but yeah, thanks! See my comment from before the review request about the issue template config file.

docs/release-notes.rst Outdated Show resolved Hide resolved
@cyschneck
Copy link
Contributor Author

Do you think it would still be useful to include the link within the Feature Request Issue Template? Seems like it would be handy in case anyone missed the alternative link

@anissa111
Copy link
Member

Do you think it would still be useful to include the link within the Feature Request Issue Template? Seems like it would be handy in case anyone missed the alternative link

Hmmm. I don't think I have a strong opinion, but I would lean towards taking it out of the request template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anissa111 anissa111 anissa111 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@cyschneck cyschneck

Labels
developer feature For development standardization / best practices / enhancement documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue]: Add link to feature request form
2 participants
@cyschneck @anissa111