Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger a subset of tests #513

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Nov 9, 2023

PR Summary

Closes #512

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@cyschneck cyschneck self-assigned this Nov 9, 2023
@cyschneck cyschneck added documentation Improvements or additions to documentation testing Issue related to testing labels Nov 9, 2023
@cyschneck
Copy link
Contributor Author

cyschneck commented Nov 9, 2023

Looks like there is a bug in Github Action when using paths-ignore in pull_request (actions/runner#2324). paths-ignore will work when: 1.) creating a new PR and 2.) pushing a change that only impacts the files included in paths-ignore. However, when a commit is added to the PR outside of the paths-ignore list, then the workflow will ignore all files in paths-ignore for all future commits

I will convert the paths-ignore files into verify-changed-files with some conditional statements on jobs running within a workflow. Instead of fully ignoring the file, the workflow should skip jobs when only specific files/folders are edited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update which tests run for file updates
1 participant