Update carousel_content.json to remove broken link #80
Conversation
this carousel content was placeholder that should've been removed. The youtube link is not real, it would ideally be a collage of three images.
✅ Deploy Preview for earth-information-center ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I've gotten a separate request to include images in the carousel component as well. I think by passing along an extra key in the carousel-content metadata ( |
|
compare: https://deploy-preview-80--earth-information-center.netlify.app/stories/immersive_earth with the requested mockup:
|
|
After explaining the lift to implement images (with thumbnails underneath) in the carousel we got a compromise proposal to break out the carousel:
All we would need for this is a color block background. Can we make that happen? |
|
👋 |
|
Aha! I had no idea that styling was exposed there. This gives me so much more flexibility, thanks so much @hanbyul-here. You're my hero! |
|
stories/locfeature.IMMER.mdx
Outdated
| @@ -25,10 +25,181 @@ taxonomy: | |||
| --- | |||
|
|
|||
| import Carousel from "../overrides/common/embedded-video-carousel"; | |||
| import contentArray from './locfeature.IMMER/carousel_content.json'; | |||
| import contentArray from './locfeature.IMMER/carousel_content'; | |||
There was a problem hiding this comment.
Carousel component doesn't seem to be necessary anymore?
There was a problem hiding this comment.
Yes, good call. I removed it from the .mdx file.
|
@hanbyul-here is it possible to merge this in and deploy to prod? @slesaad & @j08lue |
this carousel content was placeholder that should've been removed. The youtube link is not real, it would ideally be a collage of three images (I think I had composited them with the thumbnail).
In the future, it could be good to display a thumbnail instead of a youtube video if one is present in the carousel-content.json.