Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PR template validation #71

Closed
wants to merge 1 commit into from

Conversation

stephenkilbourn
Copy link

@stephenkilbourn stephenkilbourn commented Nov 28, 2023

What am I changing and why

I've added a bit of clarification on the PR template and then added a github action to validate that a description other than the text in the PULL_REQUEST_TEMPLATE.md is used.

How to test

This can be seen by creating a PR and not editing the template. Screenshot of that case:
Screenshot 2023-11-28 at 10 35 03 AM

Now that the template is edited, look to see that the test step has passed.

⚠️ Checks

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for earth-information-center ready!

Name Link
🔨 Latest commit d37c4e4
🔍 Latest deploy log https://app.netlify.com/sites/earth-information-center/deploys/65662482d1bc110008f12492
😎 Deploy Preview https://deploy-preview-71--earth-information-center.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

PR description is too short and seems to not fulfill PR template, please fill in

@stephenkilbourn stephenkilbourn linked an issue Nov 28, 2023 that may be closed by this pull request
1 task
@j08lue
Copy link
Collaborator

j08lue commented Mar 28, 2024

Closing for now. I think we should first make the PR template more accessible, before considering to enforce compliance.

@j08lue j08lue closed this Mar 28, 2024
@j08lue j08lue removed their request for review March 28, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise PR template
2 participants