Change hover,focus style for theme card, add screen reader only heading #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for earth-information-center ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sandrahoang686
approved these changes
Nov 22, 2023
|
Looking good Hanbyul! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sandrahoang686 In case you are touching the same file, I changed the
focusStylefromcommon/styleto have primary color outline. I left outhoverStyleeven though themeCard doesn't use it anymore. Let's clean out after? 😬@faustoperez As I mentioned in the issue, it is not straightforward to style the story card from the instance side. I left that style out.