change hyperweb embed url to explicitly include index.html #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for earth-information-center ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What am I changing and why
Changing url to explicitly include
index.htmlso it embeds correctly, see current state ofstaging.earth.gov/stories/hyperwall:How to test
Still working on getting approval for a deploy preview domain name so unfortunately testing has to be done on
staging.earth.govwhich means we need to merge todevelopto see if it works. I'm really sorry folks... I promise we won't make a habit of this, I will try and get a deploy preview domain sorted so that we can test this on the auto-generated previews in the future but I don't think I can get it done on a turnaround time of ~1 day.veda-uisubmodule is needed and only done so if that's the case.