Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bug in assigning uselessTripletSeed #1269

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

matthewstortini
Copy link
Contributor

Just fixing the bug we saw pop up in the nightly validation.

Dave, the other changes are very trivial ones that you asked for in the last PR from Giani that we closed. Hope it's fine I included them.

@FNALbuild
Copy link
Collaborator

Hi @matthewstortini,
You have proposed changes to files in these packages:

  • CalPatRec

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for ab860ae: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

Copy link
Collaborator

@kutschke kutschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to this quickly. I have one question inline and one suggestion for a future PR.

CalPatRec/src/AgnosticHelixFinder_module.cc Show resolved Hide resolved
CalPatRec/src/AgnosticHelixFinder_module.cc Show resolved Hide resolved
@kutschke kutschke self-assigned this May 22, 2024
@kutschke kutschke requested a review from brownd1978 May 22, 2024 16:48
@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at ab860ae.

Test Result Details
test with Command did not list any other PRs to include
merge Merged ab860ae at 2149850
build (prof) Log file. Build time: 12 min 44 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy 🔶 0 errors 437 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at ab860ae after being merged into the base branch at 2149850.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Copy link
Collaborator

@kutschke kutschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the request to follow up in later PRs with the requests made during the review and in issue #1270 .

Please submit the follow up work in self contained, reviewable PRs rather than in fewer PRs each covering many topics.

@kutschke kutschke merged commit a8f0771 into Mu2e:main May 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants