Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test over multiple python versions #118

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ianwesleyarmstrong
Copy link

@ianwesleyarmstrong ianwesleyarmstrong commented Jul 25, 2023

I started with the currently supported python versions and any minor versions of delta lake > 1.0 - I'm happy to adjust these as needed. I thought it also might be worthwhile to test over different versions of pyspark, so I included the minor versions > 3 as well:

pyspark-version: ["3.1", "3.2", "3.3", "3.4"]

@ianwesleyarmstrong
Copy link
Author

ianwesleyarmstrong commented Jul 25, 2023

I've been running the tests on my fork and it appears that python 3.11 may cause some problems - I'll remove that for the time being.

https://github.com/ianwesleyarmstrong/mack/actions/runs/5652132175

@MrPowers
Copy link
Owner

MrPowers commented Oct 1, 2023

How does this deal with the Delta Lake / PySpark versions that are incompatible?

I don't think mack supports Delta 1.0.

Here are the version combinations I think we should run (Delta Lake version | PySpark version):

2.4.x | 3.4.x
2.3.x | 3.3.x
2.2.x | 3.3.x
2.1.x | 3.3.x
2.0.x | 3.2.x

This comes from the docs.

@ianwesleyarmstrong
Copy link
Author

ianwesleyarmstrong commented Nov 1, 2023

How does this deal with the Delta Lake / PySpark versions that are incompatible?

I modified it to only test those pairs listed in the docs using Python 3.10 like you suggested

Successful run

Happy to make any other suggestion improvements you find! @MrPowers

Copy link

@jaceklaskowski jaceklaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and just learnt that mack uses poetry 👏👏👏 )

@andreale28
Copy link

Hi @MrPowers, Is there any updates on this branch? I'm looking forward to using mack on pyspark 3.4.1 and delta-spark 2.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants