Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caplitalized first letter of each word #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DavidTkac
Copy link

Description

Capitalized first letters of folders titles

What

Added capital letters to each word

Why

For better organization and easier reading

How

Through terminal

Verification Steps

Check if the capitals are there

Checklist:

  • This pr is linked to the related trello card
  • My code follows the style guidelines of this project
  • I have requested a code review from (at least) two team members
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • This change has been verified by another team member

@evanhearne
Copy link
Collaborator

@DavidTkac it seems that the files were deleted, I looked through your branch, couldn't find the files. We may need to make another branch.

Copy link
Contributor

@laurafitzgerald laurafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a Request changes status to this pr to block merging.

@laurafitzgerald
Copy link
Contributor

@evanhearne it's possible that the git add didn't work here. As the files are new you have to specific about adding those to the commit. So it may look like the files are there locally but are not getting picked up. Can you paste the output of git status for the local copy of this branch to confirm.

@evanhearne
Copy link
Collaborator

evanhearne commented Feb 1, 2019 via email

@evanhearne
Copy link
Collaborator

On branch capitalization-policies
Your branch is up to date with 'davidtkac/capitalization-policies'.

nothing to commit, working tree clean

@laurafitzgerald
Copy link
Contributor

@evanhearne could you check whether the files exist locally for @DavidTkac

@laurafitzgerald
Copy link
Contributor

@evanhearne the change looks better now. I'm seeing file name changes only rather than files being removed. Just needs a rebase and conflicts to be resolved and then you are good.

@DavidTkac
Copy link
Author

@evanhearne please review

@evanhearne
Copy link
Collaborator

@laurafitzgerald thanks for looking at that for me, I have looked at the files also and they look fine. @DavidTkac we will go through rebasing on Friday as I won't be in Thursday. I have shown the git commands file in /docs/ which you can look at if you'd like to try it tomorrow.

@evanhearne
Copy link
Collaborator

@DavidTkac let's go through this today.

@evanhearne
Copy link
Collaborator

@DavidTkac please change file links in files so that all fine names allow all pages to be opened freely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants