-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add referencing via lmdb for downloader, deletion and mainloop in bitswap libp2p #16073
Open
svv232
wants to merge
12
commits into
sai/bitswaplibp2p
Choose a base branch
from
sai/bitswaplip2phelperdefinitions
base: sai/bitswaplibp2p
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svv232
changed the title
Extending libp2p helper lib
modifying downloader, deletion and mainloop in bitswap libp2p
Sep 18, 2024
svv232
changed the title
modifying downloader, deletion and mainloop in bitswap libp2p
Add referencing via lmdb for downloader, deletion and mainloop in bitswap libp2p
Sep 18, 2024
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
1 similar comment
!ci-build-me |
!ci-build-me |
georgeee
reviewed
Sep 20, 2024
@@ -14,7 +14,7 @@ libp2p_helper: ../../libp2p_ipc/libp2p_ipc.capnp.go | |||
test: ../../libp2p_ipc/libp2p_ipc.capnp.go | |||
cd src/libp2p_helper \ | |||
&& (ulimit -n 65536 || true) \ | |||
&& $(GO) test -short -timeout 40m | |||
&& $(GO) test -short -timeout 60m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, that is short 😁
is this timeout justified by having to run more tests?
could it have been accidentally leaked from development process?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.