-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor delete to remove in libp2p bitswap and extend api of libp2p ipc for bitswap #16072
base: compatible
Are you sure you want to change the base?
Conversation
!ci-build-me |
@@ -332,7 +332,7 @@ struct Libp2pHelperInterface { | |||
result @1 :ValidationResult; | |||
} | |||
|
|||
struct DeleteResource { | |||
struct RemoveResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit odd that we use tag below but not here, do you have an answer why?
@@ -52,14 +52,14 @@ func extractRootBlockList(l ipc.RootBlockId_List) ([]root, error) { | |||
return ids, nil | |||
} | |||
|
|||
func (m DeleteResourcePush) handle(app *app) { | |||
idsM, err := DeleteResourcePushT(m).Ids() | |||
func (m RemoveResourcePush) handle(app *app) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the delete to remove name change just for the sake of better names or there is a more explicit reason behind int?
No description provided.