GD-579: Part2: Minimize return_value_discarded warnings
#582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSchulze
force-pushed
the
GD-579-2
branch
from
3af652b
to
d5ca7ba
Compare
…configuration # Why If the default settings for warnings are changed to a more detailed level, many warnings are displayed. # What - fix debug/gdscript/warnings/return_value_discarded warnings **But we have to deactivate it in the end, because the fluent style of the asserts leads to many of these warnings.** Unfortunately, setting the annotation `@warning_ignore(“return_value_discarded”)` at class level in the test still doesn't work.
MikeSchulze
force-pushed
the
GD-579-2
branch
from
d5ca7ba
to
3c8b09a
Compare
MikeSchulze
changed the title
Part2: Minimize warnings in debug mode with any warning is configurationPart2: Minimize return_value_discarded warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If the default settings for warnings are changed to a more detailed level, many warnings are displayed.
What
But we have to deactivate it in the end, because the fluent style of the asserts leads to many of these warnings. Unfortunately, setting the annotation
@warning_ignore(“return_value_discarded”)at class level in the test still doesn't work.