Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Audio Switching #49

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dsmurfin
Copy link
Collaborator

@dsmurfin dsmurfin commented Apr 6, 2024

This PR adds support for audio switching using the methods discussed in #38, #36 and #42

Changes:

  • Renamed defaultCameraDeviceTypes to defaultVideoDeviceTypes
  • Deprecated initializer
  • Added new initializer: init(captureSessionPreset:defaultCameraPosition:defaultVideoDeviceTypes: defaultAudioDeviceTypes:configurator:)
  • Add removeVideoCaptureDevice
  • Modify enableVideoDataOutput to allow specific of device when nil to match switchToVideoDevice
  • Add switchToAudioCaptureDevice, removeAudioCaptureDevice to match video methods
  • Rework enableAudioCaptureDevice to match video

@dsmurfin
Copy link
Collaborator Author

dsmurfin commented Apr 6, 2024

@YuAo this PR represents changes as discussed previously. The failing tests are all testPlayerVideoOutput_iOS which does not test any of the code impacted by this PR, and which I believe may need a longer timeout due to some environmental changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant