Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/high resolution screenshot #37

Open
wants to merge 67 commits into
base: master
Choose a base branch
from

Conversation

seankmartin
Copy link

@seankmartin seankmartin commented Jul 29, 2024

Feature goal:
Support taking cropped screenshots from neuroglancer of only the data panels. Support taking these at x1, x2, or x4 scale.
In x2 and x4 scale, the canvas is resized. This means that 2D panels kind of "zoom out" to support the extra pixels. 3D panels on the other hand keep their view fixed, but have more pixels in the framebuffer.

Overall idea of files/classes:

  1. The python integration ScreenshotHandler is what actually interacts with the data to try and grab screenshot data, and repeatedly grab statistics while this is loading.
  2. The neuroglancer ScreenshotManager interacts with the display context to start the ScreenshotHandler process. It also receives information from the ScreenshotHandler and passes this on to the screenshot UI menu when appropriate. It saves the file when complete, and stops screenshots automatically if they hang.
  3. The ScreenshotDialog handles the user input to trigger actions in the ScreenshotManager, and shows updates from the ScreenshotManager to the user.

src/ui/screenshot_menu.ts Outdated Show resolved Hide resolved
src/ui/screenshot_menu.ts Outdated Show resolved Hide resolved
src/ui/screenshot_menu.ts Outdated Show resolved Hide resolved
src/util/screenshot.ts Outdated Show resolved Hide resolved
src/viewer.ts Outdated Show resolved Hide resolved
src/sliceview/volume/renderlayer.ts Outdated Show resolved Hide resolved
src/ui/screenshot_menu.ts Outdated Show resolved Hide resolved
src/ui/screenshot_menu.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant