refactor screenshot code #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (blob) { | ||
| const link = document.createElement("a"); | ||
| link.href = URL.createObjectURL(blob); | ||
| link.download = "screenshot.png"; |
There was a problem hiding this comment.
suggestion (non-blocking): I would prefer a more meaningful download name (potentially one that uses the workspace name or active neurons) but we can keep it like this until it becomes a request from the customer (if it happens)
There was a problem hiding this comment.
@afonsobspinto i have updated the code for both screenshot and recording files naming with the workspace name
afonsobspinto
approved these changes
Oct 2, 2024
aranega
approved these changes
Oct 2, 2024
applications/visualizer/frontend/src/components/viewers/ThreeD/SceneControls.tsx
Outdated
Show resolved
Hide resolved
aranega
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The use of preserveDrawingBuffer: true in the WebGL renderer can negatively impact performance. This setting is typically used to retain canvas content for tasks like taking screenshots. However, when preserveDrawingBuffer is set to false (the default), WebGL clears the drawing buffer after each frame, allowing for efficient memory management and optimal performance. When set to true, the buffer contents are preserved between frames, leading to increased memory usage and reduced rendering efficiency, which can significantly affect overall performance.
Solution: By default, preserveDrawingBuffer is set to false to improve performance during normal rendering.
A temporary WebGL renderer with preserveDrawingBuffer: true is created only when taking a screenshot to ensure the content is retained without affecting the performance during regular use.
Screen.Recording.2024-10-02.at.4.38.54.PM.mov