Build eigen (autotools) #3487
Open
Build eigen (autotools) #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're now able to build eigen if it doesn't exist or if we pass the --enable-build-libraries option. We also don't require pkg-config support, but still use it to find the location of the headers (which we'll need on Debian systems where they're install in /usr/include/eigen3).
mahrud
reviewed
Sep 19, 2024
| TARFILE = eigen-$(VERSION).tar.gz | ||
| LICENSEFILES = COPYING.* README.md | ||
|
|
||
| CONFIGURECMD = true |
There was a problem hiding this comment.
I think you still want to run configure for best results, because it checks for CPU features (e.g. SIMD) and (presumably) stores those in a custom header.
There was a problem hiding this comment.
According to the docs:
The header files are the same for all platforms. It is not necessary to use CMake or install anything.
There's some CPU feature stuff in CMakeLists.txt, but it looks to be for enabling them just for eigen's own tests and examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #3485 (comment), we add an option to build eigen to the autotools build.
We also update the check to see if eigen already exists on the system so that it doesn't require pkg-config to know about eigen -- all that matters is whether we can find the headers. We still use pkg-config to get any flags we might need to find those headers.
Here's a link to a successful build with this update: https://github.com/d-torrance/M2/actions/runs/10933847386/job/30352967367