Add finite limit to virtual memory used when checking msolve #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than allowing unlimited virtual memory, we increase the upper bound to 1.5 GB, which should still allow all the tests to pass.
|
(I just cancelled the builds because they weren't going to test this change anyway.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than allowing unlimited virtual memory, we increase the upper bound to 1.5 GB, which should still allow all the tests to pass.
Here's an example of the tests passing after this commit: https://github.com/d-torrance/M2/actions/runs/10561928026/job/29258736811
I ran the tests a bunch of times locally, incrementing the upper bound by 100,000 until they all passed. By 1.3 GB, they all passed but one (test/diff/diff_nonradical_shape-qq.sh), and then they all passed at 1.4 GB. I figured I'd round up a bit more to 1.5 GB just in case.