Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/create an omnisearch #841

Closed
wants to merge 126 commits into from
Closed

Feat/create an omnisearch #841

wants to merge 126 commits into from

Conversation

helakaraa
Copy link
Contributor

No description provided.

@helakaraa helakaraa requested a review from ptitFicus July 1, 2024 11:28
@helakaraa
Copy link
Contributor Author

helakaraa commented Jul 1, 2024

Reviewed By @ptitFicus

Backend

  • Search query : modify the backend search query in order to be able to search with a starting words.
  • Check if a user has an Admin right or Izanami Admin right => so we have no need to filter on projects ..
  • Check if we can create an index on a view in postgresql ==> only possible on materializedview and it needs a refresh query when ever we add something to tables (https://www.postgresql.org/docs/current/rules-materializedviews.html).
  • Change query variable to query list in search query.

Frontend

  • Don’t show search button, if a user has no tenant.
  • Add tenant cloud icon in the button of the search modal.
  • Remove the command K shortcut of the search button.
  • Replace "Esc"  by "Close".
  • Add a clear icon in search input in order to remove easily the typed words.
  • Add focus on search typing input field.
  • Modify SearchModalContent.tsx (change the location of some functions , use debounce query directly in onChange input function).
  • Search by tenant must be shown even when we are in the ADMIN ZONE (use the useSearchParams).
  • Search a project : navigate directly to the page of the project not to the tenant list of projects.

Both

  • Add search view for contexts.

@helakaraa
Copy link
Contributor Author

helakaraa commented Jul 10, 2024

Added modifications

  • Change fts to fuzzystrmach query.
  • Add index on name and description fields for searchable entities.
  • Add search view for projects contexts and global contexts.
  • Add filter on projects contexts and global contexts.
  • Add Extensions (fuzzystrmatch and pg_trgm) to postgresSQL.
  • Limit the number of shown search results ( 10 results with a similarity of 0.4).

@ptitFicus
Copy link
Member

image

When "All tenants" is selected, placeholder message should be "Search in all tenants"

@ptitFicus
Copy link
Member

When I am on a project page, searching for a feature that's on the page does not filter the feature table when I select seaech result.

@ptitFicus
Copy link
Member

image

Global subcontext icon is wrong, it should be the planet with the filter, as for "prod" context

@ptitFicus
Copy link
Member

image

This should probably be "Click to search", since we can't actually type in this field

@ptitFicus
Copy link
Member

When searching tenant project of features with a tenant admin user (that has no specific rights on these projects), search returns nothing.

@ptitFicus
Copy link
Member

Search does not find project on which user has read/write/admin rights (without being a tenant or izanami admin)

@helakaraa
Copy link
Contributor Author

helakaraa commented Jul 22, 2024

Reviews of the team:

  • Show history of search.
  • Regroup global contexts with projects contexts in one section as contexts.
  • Correction of the project link having a description.
  • Correction of contexts links (if we have a context dev and dev-test and we click on dev-test we see that even dev is opened).
  • Change the search link of a context to search query param {contexts/?query= …… query params}).
  • Icon search global context to be modified.
  • Remove tenant name in display search if we are already on a selected tenant .
  • Icon search to minimize size.
  • If we can add the option to search only on a specific category ( example search only in projects).
  • We need to see if we can make the rank of the query as global param , we added it as default to 0.2.
  • In display search results, we should highlight the searched word (uppercase , underlining …).
  • Add wasm scripts for search field.
  • Remove the name of the project when we display the ApiKeys ( because a key can be related to many projects)..

@ptitFicus
Copy link
Member

ptitFicus commented Aug 4, 2024

Closed since 2f09781 has been merged, remaining tasks are in #857

@ptitFicus ptitFicus closed this Aug 4, 2024
@ptitFicus ptitFicus deleted the feat/Create-an-Omnisearch branch September 20, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants